-
Notifications
You must be signed in to change notification settings - Fork 1
Cross search optimization #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter-change initiated Co-authored-by: Aaro <aaro.koivukangas@gmail.com>
Co-authored-by: Aaro Koivukangas<aaro.koivukangas@gmail.com>
Co-authored-by: Aaro Koivukangas<aaro.koivukangas@gmail.com>
…ter-change initiated Co-authored-by: Aaro <aaro.koivukangas@gmail.com>
Co-authored-by: Aaro Koivukangas<aaro.koivukangas@gmail.com>
…owdatabase into cross-search-optimization
iritmaximus
approved these changes
Nov 21, 2024
Collaborator
iritmaximus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched prisma.findMany() to prisma.rawSQL-Left Join. Local GET crosssearch calls went from ~10s to ~3s.
Also expanded tests for this GET call to check that user rights are handled correctly, expanded testdb for better cross search testing, made necessary changes to existing tests to match these updates, added a placeholder unit test, because I removed the existing ones as they tested a thing that didn't make it.