frontend check that an update has a reference selected #599
Conversation
kaarleol
force-pushed
the
mandatory-reference
branch
from
45b1d8d to
c405f2f
Compare
frontend/src/validators/validator.ts
Outdated
|
|
||
| // new references have rowState = 'new', old ones don't have a rowState and references that will be deleted have rowstate='removed' | ||
| // so checking the update has at least one reference that's not queued for removal | ||
| let nonRemovedReference = false |
There was a problem hiding this comment.
const nonRemovedReferences = references.some(ref =>!ref.rowState || ref.rowState === 'removed')
|
@kaarleol I think the ts error is due to the path alias ('@/backendTypes') in import. Notice how it is backends tsc that fails? That is because backend code uses some files from frontend, but it doesn't know about frontend path aliases. That's why you can't use path aliases in those files, you must use relative paths. For the same reason you shouldn't import other frontend files into these shared files. I think I wrote a comment about these limitations into the backendTypes file, but the file/folder structure is now a bit different so it's less obvious to see it. I'll try to make a fix to the entire shared directory / filenames later, and I'll make it a PR so your group can approve and merge it. There's a couple very confusing things that I left there. |
kaarleol
force-pushed
the
mandatory-reference
branch
from
c63ffa4 to
242e37c
Compare
…ot just something random
I just can't find a way around the ts error