Skip to content

Conversation

@ShootingStar91
Copy link
Contributor

No description provided.

@ShootingStar91 ShootingStar91 marked this pull request as ready for review December 8, 2024 14:24
@ShootingStar91
Copy link
Contributor Author

  • Moved backendTypes.ts from frontend/src to frontend/src/shared/types as separate files. All shared types are now imported from that folder, but they are divided into separate files that are imported via index.ts.
  • frontend/src/types.ts was removed, it had some calculation-functions which are now in shared/calculations.ts, as well as one type which is in types folder
  • fixed the copied types in reference validator to be correctly imported instead of copied

Merge this if you want, or if it disrupts your workflows too much you can leave it and I will merge after your group is done. But it'd be nice if you took a look at it in case you have opinions on any changes.

@ShootingStar91 ShootingStar91 changed the title move backendTypes.ts to src/shared/types Move all shared code to frontend/src/shared & divide types into separate folders Dec 8, 2024
Copy link
Collaborator

@iritmaximus iritmaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That was a lot of files changed, took a while to even scroll all of them

@iritmaximus iritmaximus merged commit c3f41a7 into main Dec 8, 2024
4 checks passed
@iritmaximus iritmaximus deleted the refactor-shared-code-better branch December 8, 2024 22:29
@iritmaximus
Copy link
Collaborator

This seemed like a clear improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants