Conversation
|
bugbot run |
|
@codex review |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR transitions the nowledge-mem plugins from local filesystem-based deployment to marketplace-driven installation, updates plugin versions (Codex CLI to 0.1.4, OpenClaw to 0.8.19), and refactors the OpenClaw plugin's corpus supplement registration to gracefully handle unavailable host registration with fallback behavior while preserving user intent. Changes
Sequence Diagram(s)sequenceDiagram
participant Host as OpenClaw Host
participant Plugin as nowledge-mem Plugin
participant API as Host API
participant StatusTool as Status Tool
Plugin->>API: registerMemoryCorpusSupplement()
alt Registration Successful
API-->>Plugin: Success
Plugin->>Plugin: corpusSupplementActive = true
Plugin->>StatusTool: corpusSupplementActive = true
StatusTool-->>Host: "corpus supplement active"
else Registration Fails
API-->>Plugin: Error
Plugin->>Plugin: corpusSupplementActive = false
Plugin->>Plugin: corpusSupplementRegistrationError = error.message
Plugin->>StatusTool: corpusSupplementActive = false<br/>corpusSupplementRegistrationError = message
StatusTool-->>Host: "configured but unavailable"<br/>"plugin uses own recall path"
end
Host->>Plugin: before_prompt_build
Plugin->>Plugin: skipSearchRecall = corpusSupplementActive ? false : true
alt Skip Search Recall
Plugin->>Plugin: Use Working Memory only
else Perform Search Recall
Plugin->>Plugin: Perform searchRich() + recall
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@integrations.json`:
- Around line 133-136: The install.command currently only runs the marketplace
add step and does not actually install the plugin; update the "install.command"
entry to either (A) call the explicit install step if the Codex CLI supports one
(e.g. add a chained "codex plugin install <plugin-id>" or equivalent after
"codex plugin marketplace add") or (B) change the text to document that users
must open the interactive /plugins TUI and enable/install the plugin manually
after adding the marketplace; also adjust the "configRequired" value to not
claim that enabling "[plugins.\"nowledge-mem@nowledge-community\"] enabled =
true" will install the plugin (make it clear it requires prior installation),
and replace the "updateCommand" fallback so it performs an actual
refresh/upgrade of the marketplace/plugin (or remove the redundant marketplace
add) instead of only re-running "marketplace add".
In `@nowledge-mem-openclaw-plugin/src/tools/status.js`:
- Around line 104-116: The status message currently claims "Fallback active:
Nowledge Mem still injects Working Memory and uses its own recall path" under
the corpusSupplementConfigured && !corpusSupplementActive branch which
overpromises fallback behavior when session context is disabled; update this
logic to only show the fallback/injection message when sessionContext is enabled
(or when the recall handler is actually registered) by checking the
sessionContext flag (cfg.sessionContext or the local sessionContext variable) or
by referencing the actual recall registration state instead of unconditionally
printing it; keep the existing checks for corpusSupplementConfigured,
corpusSupplementActive, and corpusSupplementRegistrationError and only append
the fallback line when sessionContext is true.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b9cd8ced-91cd-4a18-8f29-3de410d12b41
⛔ Files ignored due to path filters (1)
nowledge-mem-openclaw-plugin/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (13)
.agents/plugins/marketplace.jsonintegrations.jsonnowledge-mem-codex-plugin/.codex-plugin/plugin.jsonnowledge-mem-codex-plugin/CHANGELOG.mdnowledge-mem-codex-plugin/README.mdnowledge-mem-npx-skills/skills/check-integration/SKILL.mdnowledge-mem-openclaw-plugin/CHANGELOG.mdnowledge-mem-openclaw-plugin/openclaw.plugin.jsonnowledge-mem-openclaw-plugin/package.jsonnowledge-mem-openclaw-plugin/src/hooks/recall.jsnowledge-mem-openclaw-plugin/src/index.jsnowledge-mem-openclaw-plugin/src/tools/status.jsnowledge-mem-openclaw-plugin/tests/status-tool.test.mjs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc6654aedf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
bugbot run |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit faf4fe3. Configure here.
1 participant
Note
Medium Risk
Updates host integration behavior in OpenClaw (corpus supplement/recall gating and status reporting) and changes Codex installation/update flow to marketplace commands, which could affect setup and runtime recall paths if assumptions are wrong across host versions.
Overview
Moves the Codex CLI integration to a marketplace-first setup: adds a repo
.agents/plugins/marketplace.jsonentry, updatesintegrations.json, and rewrites Codex plugin docs to usecodex plugin marketplace ...(with legacycodex marketplace ...fallbacks) plus explicit/pluginsinstallation and thenowledge-mem@nowledge-communityconfig key.Bumps plugin versions (
nowledge-memCodex0.1.4, OpenClaw0.8.19) and updates the npxcheck-integrationguidance accordingly.Fixes OpenClaw corpus-supplement fallback semantics: the plugin no longer mutates
cfg.corpusSupplementon registration failure, tracks configured vs runtime-active supplement state, gates Context Engine and hook recall based on runtime activation, and expandsnowledge_mem_statusoutput/tests to explain fallback reasons and avoid claiming recall fallback whensessionContextis disabled.Reviewed by Cursor Bugbot for commit faf4fe3. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Release Notes
Documentation
Bug Fixes
Chores