fix(core): prevent infinite loops with hard cap on consecutive same-name tool calls#1
Closed
noxymon wants to merge 4 commits into
Closed
fix(core): prevent infinite loops with hard cap on consecutive same-name tool calls#1noxymon wants to merge 4 commits into
noxymon wants to merge 4 commits into
Conversation
…oops (google-gemini#25671) - Added CONSECUTIVE_SAME_TOOL_NAME_THRESHOLD (50) and THINKING_TOOL_LOOP_THRESHOLD (15) to LoopDetectionService. - Enhanced loop detection to track consecutive calls to the same tool name even if arguments differ. - Updated LoopDetected event to carry specific loop details. - Improved UI alerting to display detailed information about the detected loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a hard cap for consecutive calls to the same tool name to prevent infinite loops, especially in "thinking" tools where arguments (like thought numbers) change each time. It also enhances the loop detection event to carry more details to the UI.
Details
Related Issues
Fixes google-gemini#25671
How to Validate
pm test -w @google/gemini-cli-core -- loopDetectionService.test.ts to verify the logic.
Pre-Merge Checklist