Background the wait for /dev/shm so vserver start can run post-start scripts#36
Merged
Conversation
Upon canary testing we discovered that the original version created a live lock: `vserver start` blocked on the iupui_npad init scripts returning before running the post-start script that mounts /dev/shm/iupui_npad, and the npad initscripts waited for /dev/shm/iupui_npad to be mounted before returning. This change allows the initscript wait to run in the background.
Contributor
|
LGTM |
gfr10598
approved these changes
Mar 8, 2017
|
|
||
| ( | ||
| # Wait until /dev/shm/iupui_npad is mounted by the | ||
| # vserver start sequence. |
Contributor
There was a problem hiding this comment.
Please add a comment explaining why it must be this way.
This was referenced Mar 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon canary testing we discovered that the original version created a live lock:
vserver startblocked on the iupui_npad init scripts returning before running thepost-startscript that mounts /dev/shm/iupui_npad, and the npad initscripts waited for/dev/shm/iupui_npadto be mounted before returning.This change allows the initscript wait to run in the background, thus preventing the live lock.
This change is