Add set SO_KEEPALIVE option on prometheus exporter connections.#39
Merged
Conversation
Contributor
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidestream is a core service (must run on all nodes) and scraper alerts depend on the metrics it provides.
This PR addresses #38
In practice, we are observing M-Lab servers holding ESTABLISHED TCP connections when the remote end has disconnected (e.g. rsyncd, ndt, sidestream exporter). To prevent this we need to set SO_KEEPALIVE on the connections so they eventually reset.
This change is