fix: correct bundled sigstore from dev dependency conflict#9740
Merged
Conversation
reggi
approved these changes
Jul 10, 2026
Contributor
|
Thanks for your help on this, we need a check to make sure this doesn't happen again 😢 |
Merged
This was referenced Jul 10, 2026
yihui
added a commit
to yihui/lite.js
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #9722.
mock-registrypinned@npmcli/arborist@^9.1.2, which meant the local workspace version wasn't linked and the dependency was pulled from the registry instead.sigstore@^4got installed at the root node_modules and^5was put intoworkspaces/libnpmpublish/node_modules. The dev-only^4was then excluded when npm was packed.Fix:
mock-registry: arborist^9.1.2->^10.0.0workspaces/arborist: validate-npm-package-name^7.0.2->^8.0.0(need to release a patch for arborist)node . run dependenciesThe packed tarball now contains
package/node_modules/sigstoreandpublish --dry-runfrom the extracted tarball succeeds.