chore(arborist): add missing registry mock in bin links reify test#9746
Merged
Conversation
The 'bin links adding and removing' test in reify.js reifies rimraf@2.7.1 without setting up a mock registry. Add createRegistry(t, true) so the test does not depend on the real registry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 66949dc3-2949-4333-890d-1086c50f5019
saquibkhan
approved these changes
Jul 10, 2026
martinrrm
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bin links adding and removingtest inworkspaces/arborist/test/arborist/reify.jsreifiesrimraf@2.7.1without setting up a mock registry.This adds
createRegistry(t, true)so the test uses the mock registry instead of depending on the real one.