Skip to content

fix: npm unstar#2204

Closed
ruyadorno wants to merge 2 commits intonpm:latestfrom
ruyadorno:refactor-star-tests
Closed

fix: npm unstar#2204
ruyadorno wants to merge 2 commits intonpm:latestfrom
ruyadorno:refactor-star-tests

Conversation

@ruyadorno
Copy link
Copy Markdown
Contributor

  • Refactored lib/star.js
  • Fixes npm unstar by adding a lib/unstar.js alias/cmd
  • Add tests for lib/star.js and lib/unstar.js

@ruyadorno ruyadorno requested a review from a team as a code owner November 19, 2020 21:22
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Nov 19, 2020
- Refactored lib/star.js
- Fixes `npm unstar` by adding a lib/unstar.js alias/cmd
- Add tests for lib/star.js and lib/unstar.js

Fixes: npm/statusboard#174
@ruyadorno ruyadorno self-assigned this Nov 19, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 20 milestone Nov 19, 2020
Copy link
Copy Markdown
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants