fix(arborist): fix unescaped periods#4462
fix(arborist): fix unescaped periods#4462lukekarrys merged 1 commit intonpm:latestfrom XhmikosR:patch-1
Conversation
|
Not sure why codeql would be needed; this is an eslint core rule (that should certainly be enabled) |
|
Whatever does the job, ofc. It's just that CodeQL has checks for things ESLint doesn't. |
|
We are setting codeql up on our repos, we have not done it for the cli yet but it's on the roadmap. |
@ljharb what's the eslint rule for this? |
|
@lukekarrys ah, looking into it, this specific case isn't covered; i usually have all of https://eslint.org/docs/rules/no-control-regex, https://eslint.org/docs/rules/no-div-regex, https://eslint.org/docs/rules/no-regex-spaces, https://eslint.org/docs/rules/no-invalid-regexp, and https://eslint.org/docs/rules/prefer-regex-literals enabled tho. |
References
Spotted on https://lgtm.com/projects/g/npm/cli/alerts/?mode=list. If you are not using CodeQL already, I suggest that you set it up :)