fix: fix usage of path of custom registry #8737
Merged
+67
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly handle the resolution of a path via a custom registry with a path element in the URL, when the path element is a prefix of a package name. When a custom registry with a path element is used (e.g. http://localhost:3080/npm/), then the resolution of download URLs for packages starting with the path element (in this case `npm`, so e.g. `npm-run-path`) will fail as the path element gets omitted. ## References Fixes npm#8736
owlstronaut
changed the title
owlstronaut
approved these changes
Nov 19, 2025
Contributor
owlstronaut
left a comment
owlstronaut
left a comment
There was a problem hiding this comment.
Good catch, thank you for the contribution!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle the resolution of a path via a custom registry with a path element in the URL, when the path element is a prefix of a package name.
When a custom registry with a path element is used (e.g. http://localhost:3080/npm/), then the resolution of download URLs for packages starting with the path element (in this case
npm, so e.g.npm-run-path) will fail as the path element gets omitted.References
Fixes #8736