fix(profile): streamline property setting #8842
Closed
+1
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
changed the title
watilde
changed the title
Member
|
This also undoes the purpose of this code, which is to not clear things that we aren't changing. |
Contributor
Author
|
Sounds good. I was thinking if it's better to improve FIXME, but that's right. Let me close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Replaced verbose logic (get, copy, set) with a single, atomic
set({ [prop]: value })call. This simplifies the code, improves efficiency, and eliminates potential race conditions when updating a single configuration property. 100% test coverage maintained; no test code changed.