fix: npm audit signatures for keyless attestation registries#9026
Merged
wraithgar merged 1 commit intonpm:latestfrom Feb 24, 2026
Merged
fix: npm audit signatures for keyless attestation registries#9026wraithgar merged 1 commit intonpm:latestfrom
wraithgar merged 1 commit intonpm:latestfrom
Conversation
Member
|
We tend not to accept PRs that update dependencies. We have a dependency updates PR in flight now #9027 |
9196c52 to
cb460e2
Compare
Contributor
Author
Thanks I will rebase it once it merges |
5ac20bf to
0fa2cc8
Compare
Contributor
Author
|
@wraithgar rebased and for your review |
wraithgar
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm audit signatures fails when a registry only uses keyless (Sigstore/Fulcio) attestations and doesn't provide registry signing keys. The auditedWithKeysCount guard in verify-signatures.js treats any registry without keys as unsupported, even though keyless attestations don't need registry keys at all -- the signing certificate is embedded directly in the bundle and verified through Sigstore's TUF root of trust.
This updates the check to also accept verified keyless attestations as a valid audit result, so registries that exclusively use Fulcio-based signing (like Chainguard) work correctly with npm audit signatures.
Before this change:
npm error found no dependencies to audit that were installed from a supported registry
After:
audited 1 package in 1s
1 package has a verified attestation
This change works together with the corresponding pacote fixes (pacote/pull/454)
(pacote/pull/452)
which allows keyless attestation bundles to pass the registry key matching check.