fix(arborist): fix non-idempotent linked install with workspace projects#9094
Merged
wraithgar merged 1 commit intonpm:latestfrom Mar 10, 2026
Conversation
wraithgar
approved these changes
Mar 10, 2026
manzoorwanijk
deleted the
fix/linked-strategy/idempotent-workspace-install
branch
manzoorwanijk
added a commit
to manzoorwanijk/npm-cli
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In continuation of our exploration of using
install-strategy=linkedin the Gutenberg monorepo, which powers the WordPress Block Editor.Fix two issues in
#buildLinkedActualForDiff()(introduced in #9031) that causednpm install --install-strategy=linkedto always reportchanged N packageson subsequent runs for workspace projects with cross-workspace dependencies.resolved: "file:../packages/...") but the ideal tree's workspace links hadresolved: undefined, causing a false CHANGE.fsChildrenchildren (withresolved: "file:../../../node_modules/.store/...") overwrote synthetic store entries (withresolved: "file:.store/...") inallChildren().The fix creates synthetic entries for all ideal children (not just store nodes) and uses empty
fsChildrenon the wrapper to prevent overwrites.References
Fixes #9091