fix(arborist): skip linked actual tree diff in package-lock-only mode#9108
Merged
wraithgar merged 1 commit intonpm:latestfrom Mar 16, 2026
Merged
Conversation
2 tasks
wraithgar
approved these changes
Mar 16, 2026
manzoorwanijk
added a commit
to manzoorwanijk/npm-cli
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm install --package-lock-onlycrashes withCannot read properties of undefined (reading 'children')wheninstall-strategy=linkedis set in a workspace monorepo.In
packageLockOnlymode,_loadTreesskipsloadActual()since nothing needs to be written to disk. But#buildLinkedActualForDiffis called unconditionally and tries to accessthis.actualTree.childrenwhich is undefined.Fixed by guarding the
#buildLinkedActualForDiffcall so it's skipped when there is no actual tree.Regression introduced in #9031.
References
Fixes #9105