fix(arborist): show real install script names on lockfile installs#9428
Merged
owlstronaut merged 1 commit intoMay 28, 2026
Merged
Conversation
…stead of a sentinel
owlstronaut
approved these changes
May 28, 2026
Contributor
|
🎉 Backport to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On lockfile-driven installs (
npm ci, a repeatnpm install), the allow-scripts advisory printed(install scripts present)instead of the actual script. The lockfile only recordshasInstallScript, not the script bodies, sonode.package.scriptswas empty. We now read the installed package.json from disk to recover the real scripts, and keep the sentinel only for when the package isn't on disk yet (e.g.npm cipreflight before reify).Fixes the core-js/fsevents report: https://bsky.app/profile/sebastienlorber.com/post/3mmwfy2s2p22t