fix(prune): respect allowScripts policy from package.json#9438
Open
colincasey wants to merge 2 commits into
Open
fix(prune): respect allowScripts policy from package.json#9438colincasey wants to merge 2 commits into
colincasey wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm prunewas emitting anallow-scriptsadvisory warning even when the package was explicitly approved inpackage.json#allowScripts. This PR mirrors theallowScriptsetup and testing already present inlib/commands/update.js.Note
The same
allow-scriptsadvisory warning issue was also noticed when executing other commands (e.g.;npm dedupe,npm audit fix, etc.). They are deliberately out of scope for this PR since I didn't notice them until after I filed the associated issue.Fixes #9435