Skip to content

feat: allowScripts tooling and inBundle hardening#9480

Merged
owlstronaut merged 1 commit into
npm:latestfrom
JamieMagee:jamiemagee/allowscripts-tooling-v11
Jun 3, 2026
Merged

feat: allowScripts tooling and inBundle hardening#9480
owlstronaut merged 1 commit into
npm:latestfrom
JamieMagee:jamiemagee/allowscripts-tooling-v11

Conversation

@JamieMagee
Copy link
Copy Markdown
Contributor

Pulls the non-behavioral pieces out of #9424 so they can land on v11: the collectUnreviewedScripts/strictAllowScriptsError helpers, the inBundle fixes, and an opt-in libnpmexec preflight. Nothing changes by default here, install scripts still run. The default-deny flip stays in #9424 for v12.

References

#9424

Behavior-neutral additive tooling split out of npm#9424 so it can land on
v11 without the v12 default-deny flip:

- arborist: add collectUnreviewedScripts() + strictAllowScriptsError
  (ESTRICTALLOWSCRIPTS) helpers in unreviewed-scripts.js
- arborist: isScriptAllowed() returns null for bundled deps; propagate
  inBundle through isolated reifier / isolated-classes
- libnpmexec: opt-in strict-allow-scripts preflight (only under
  --strict-allow-scripts); no default behavior change
- cli: rewrite check-allow-scripts as a wrapper over
  collectUnreviewedScripts; exclude bundled deps from rebuild/runAll
- tests for all of the above

No default install-script behavior changes; the default-deny gate stays
in npm#9424 for v12.
@JamieMagee JamieMagee force-pushed the jamiemagee/allowscripts-tooling-v11 branch from 3b20a3b to 80ae152 Compare June 3, 2026 20:45
@owlstronaut owlstronaut changed the title Split out allowScripts tooling for v11 feat: allowScripts tooling and inBundle hardening Jun 3, 2026
@owlstronaut owlstronaut merged commit 64e3f79 into npm:latest Jun 3, 2026
47 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

🎉 Backport to release/v11 created: #9483

owlstronaut pushed a commit that referenced this pull request Jun 3, 2026
Backport of #9480 to `release/v11`.

Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee JamieMagee deleted the jamiemagee/allowscripts-tooling-v11 branch June 3, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants