fix(sbom): percent-encode vcs_url qualifier in generated purls#9670
Merged
Conversation
owlstronaut
approved these changes
Jun 29, 2026
Contributor
|
🎉 Backport to |
owlstronaut
pushed a commit
that referenced
this pull request
Jun 29, 2026
Backport of #9670 to `release/v11`. Co-authored-by: UB <ubed@bugqore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both SBOM generators build a git package's purl by sticking the raw
node.resolvedstraight into thevcs_urlqualifier, so any#or&in that resolved URL escapes the qualifier value. A git dep resolving to e.g.https://github.com/foo/bar.git?a=b&c=d#1234producespkg:npm/...?vcs_url=https://github.com/foo/bar.git?a=b&c=d#1234, where a purl parser readsc=das a separate qualifier and1234as the subpath. Wrappingnode.resolvedinencodeURIComponentat both sites keeps it a single qualifier value; the existing git-url snapshots and two new assertions cover it.