Skip to content

[BUG] correctProtocol fails to correctly handle custom protocols #213

@markovejnovic

Description

@markovejnovic

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

correctProtocol("foobar://user:host@path", {}) returns "git+ssh://foobar://user:host@path".

Expected Behavior

I expect correctProtocol to return "foobar://user:host@path". I am uncertain whether this is truly expected, but this feels significantly more natural to me than the actual output.

Steps To Reproduce

A reproduction is available at typescriptlang.org.

Environment

  • Current mainline release at 97fef20.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bugthing that needs fixingNeeds Triageneeds an initial review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions