Stop defaulting git-branch, return null when unset #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about making this be |
Contributor
|
actually that might break in creative new corner cases. Maybe it's better for pacote to interpret this null, itself. |
zkat
approved these changes
Oct 18, 2017
Contributor
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
I think this is ok. It's probably better for consumer libs to interpret this, specially since they can fall back to master manually if HEAD goes awry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll need a new major I think, since it was guaranteed to be set previously.