feat: forward globalIgnoreFile option to npm-packlist#487
Open
ljharb wants to merge 1 commit into
Open
Conversation
`DirFetcher` is the entry point for packing a directory spec and calls `npm-packlist` directly. Pull `globalIgnoreFile` off the opts and pass it through to packlist so a user level ignore file (configured by callers such as the npm cli) actually reaches the walker that decides which files end up in the tarball. Includes a test that mocks `npm-packlist` to confirm the option is forwarded, and a complementary test confirming that omitting the option passes `undefined` through. The behavior on the packlist side lands in a separate npm-packlist release; this commit only adds the plumbing on the pacote side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirFetcheris the entry point for packing a directory spec and callsnpm-packlistdirectly. PullglobalIgnoreFileoff the opts and pass it through to packlist so a user level ignore file (configured by callers such as the npm cli) actually reaches the walker that decides which files end up in the tarball.Includes a test that mocks
npm-packlistto confirm the option is forwarded, and a complementary test confirming that omitting the option passesundefinedthrough. The behavior on the packlist side lands in a separate npm-packlist release; this commit only adds the plumbing on the pacote side.Required for npm/cli#9351