Skip to content

fix DX & building issues#75

Merged
npmstudy merged 11 commits intonpmstudy:devfrom
citrus327:feat/dev
Mar 11, 2024
Merged

fix DX & building issues#75
npmstudy merged 11 commits intonpmstudy:devfrom
citrus327:feat/dev

Conversation

@citrus327
Copy link
Collaborator

@citrus327 citrus327 commented Mar 11, 2024

This PR fixes the following:

  1. fix publint issues in https://publint.dev/minecat@0.7.8
    1. missing exports field
    2. module field was pointing at the wrong file
    3. fixing typing import in ts and js env
  2. rename monorepo name since pnpm will link by package name and the current monorepo package name is same as subpackage
  3. remove redundunt properties in monorepo's package.json file
  4. add clean in tsup.config.cjs
  5. ignore v8-compile-cache folder under source root

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 9ee573e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.89%. Comparing base (3a3836b) to head (9ee573e).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #75      +/-   ##
==========================================
+ Coverage   68.49%   69.89%   +1.40%     
==========================================
  Files          21       22       +1     
  Lines        1279     1269      -10     
  Branches      105      106       +1     
==========================================
+ Hits          876      887      +11     
+ Misses        403      382      -21     
Flag Coverage Δ
libargs 84.21% <ø> (ø)
minecat 65.38% <ø> (+1.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@npmstudy npmstudy merged commit 4e64dc1 into npmstudy:dev Mar 11, 2024
@citrus327 citrus327 deleted the feat/dev branch March 11, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants