Skip to content

fix(i18n): set readme text direction to 'auto'#1045

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
BobbieGoede:fix/readme-direction
Feb 5, 2026
Merged

fix(i18n): set readme text direction to 'auto'#1045
danielroe merged 1 commit intonpmx-dev:mainfrom
BobbieGoede:fix/readme-direction

Conversation

@BobbieGoede
Copy link
Contributor

We don't know the language used in the readme, so we shouldn't force/inherit the direction.

before:
Code_2026-02-05_22-39-52
after:
Code_2026-02-05_22-39-59

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 9:44pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 9:44pm
npmx-lunaria Ignored Ignored Feb 5, 2026 9:44pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the Readme.vue component by adding a dir="auto" attribute to the root article element. This change enables automatic text direction handling based on content. No modifications were made to the component's logic, event handlers, or any exported public entities. The addition consists of a single line change to the template markup.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the change: adding dir='auto' to handle readme text direction without forcing or inheriting a specific direction, matching the changeset which adds this attribute to the Readme.vue template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Merged via the queue into npmx-dev:main with commit ea25ecb Feb 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants