Skip to content

style: improve border visibility in select package section#1064

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
iiio2:style/improve-border-in-select-package-section
Feb 8, 2026
Merged

style: improve border visibility in select package section#1064
danielroe merged 2 commits intonpmx-dev:mainfrom
iiio2:style/improve-border-in-select-package-section

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 6, 2026

I think the border in select package section is less visible in both dark and light mode. We can slightly improve it.

Before: The border used --border which is very faint (oklch 0.269 in dark mode, 0.8514 in light mode)

After: The border now uses --border-hover which is more visible (oklch 0.371 in dark mode, 0.715 in light mode)

before:
border-two

after:
border-one

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 8, 2026 11:36pm
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 11:36pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 8, 2026 11:36pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The change updates a single CSS class in the compare page's Empty state: the border class is changed from border-border to border-border-hover. This is a one-line styling change with no modifications to component logic, data handling, control flow, or exported declarations.

Suggested reviewers

  • 43081j
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the styling change: improving border visibility by switching from --border to --border-hover class with specific colour value comparisons and visual examples.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe enabled auto-merge February 8, 2026 23:15
@danielroe danielroe disabled auto-merge February 8, 2026 23:18
@danielroe danielroe enabled auto-merge February 8, 2026 23:18
@danielroe danielroe added this pull request to the merge queue Feb 8, 2026
Merged via the queue into npmx-dev:main with commit 8c8f2fa Feb 8, 2026
17 checks passed
@iiio2
Copy link
Contributor Author

iiio2 commented Feb 9, 2026

Thanks.

@iiio2 iiio2 deleted the style/improve-border-in-select-package-section branch February 9, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants