Skip to content

feat: add blog menu item to mobile menu#1147

Merged
whitep4nth3r merged 2 commits intonpmx-dev:feat/atproto-blog-fefrom
colinscz:feat/add-link-to-blog-on-mobile
Feb 7, 2026
Merged

feat: add blog menu item to mobile menu#1147
whitep4nth3r merged 2 commits intonpmx-dev:feat/atproto-blog-fefrom
colinscz:feat/add-link-to-blog-on-mobile

Conversation

@colinscz
Copy link
Contributor

@colinscz colinscz commented Feb 7, 2026

Added the blog link to the mobile menu, currently in draft in case @whitep4nth3r has some additions I can contribute as a follow-up

Closes #1140

image

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 7, 2026 1:03pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 7, 2026 1:03pm
npmx-lunaria Ignored Ignored Feb 7, 2026 1:03pm

Request Review

@whitep4nth3r
Copy link
Contributor

whitep4nth3r commented Feb 7, 2026

Looks great to me!! Although I wonder if there is a more appropriate icon for the blog link.

@colinscz
Copy link
Contributor Author

colinscz commented Feb 7, 2026

Looks great to me!! Although I wonder if there is a more appropriate icon for the blog link.

@whitep4nth3r You are absolutely right, thanks for catching that - my bad! I added now the supported blog icon from the lib. It looks now like this:
image

let me know in case you want me to add the desktop menu item too and if possible at which position in the navigation you think it fits bets. :)

@whitep4nth3r
Copy link
Contributor

It's in the footer on desktop so no need to put it in the header! Looks good.

@whitep4nth3r whitep4nth3r marked this pull request as ready for review February 7, 2026 13:06
@whitep4nth3r whitep4nth3r merged commit 1ca8d10 into npmx-dev:feat/atproto-blog-fe Feb 7, 2026
6 checks passed
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Thanks for your first contribution, @colinscz! 🎊

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

@colinscz colinscz deleted the feat/add-link-to-blog-on-mobile branch February 22, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants