Skip to content

chore: don't warn for unmocked data: URLs#1224

Merged
danielroe merged 1 commit intomainfrom
chore/dont-warn-for-unmocked-data-urls
Feb 8, 2026
Merged

chore: don't warn for unmocked data: URLs#1224
danielroe merged 1 commit intomainfrom
chore/dont-warn-for-unmocked-data-urls

Conversation

@serhalp
Copy link
Contributor

@serhalp serhalp commented Feb 8, 2026

I noticed this in test logs:

[WebServer] [test-fixtures] NO FIXTURE PATTERN
[WebServer] ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
[WebServer] URL does not match any known fixture pattern
[WebServer] URL: data:application/octet-stream;base64,AGFzbQEAAAABugM3YAF/AGACf38AYAF/AX9gA39/fwBgAn98AGACf38Bf2ADf39/AX9gBH9/[...snip...]

This isn't an actual network request, so we should ignore it.

I noticed this in test logs:

```
[WebServer] [test-fixtures] NO FIXTURE PATTERN
[WebServer] ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
[WebServer] URL does not match any known fixture pattern
[WebServer] URL: data:application/octet-stream;base64,AGFzbQEAAAABugM3YAF/AGACf38AYAF/AX9gA39/fwBgAn98AGACf38Bf2ADf39/AX9gBH9/[...snip...]
````
@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 4:29pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Feb 8, 2026 4:29pm
npmx-lunaria Ignored Ignored Feb 8, 2026 4:29pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

The change modifies the global fetch override in the cache module to exclude data: URLs from fixture interception. Previously, data: URLs were eligible to receive fixture-driven responses; with this alteration, such URLs now bypass the fixture system and are fetched through the original network path. The remaining fixture processing logic for other URL types, including esm.sh handling and fallback fixture-based responses, remains unchanged.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset by explaining the problem (data: URLs triggering false fixture warnings) and the solution (bypassing fixture interception for data: URLs).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/dont-warn-for-unmocked-data-urls

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 8, 2026
Merged via the queue into main with commit 091e7e4 Feb 8, 2026
20 checks passed
@danielroe danielroe deleted the chore/dont-warn-for-unmocked-data-urls branch February 8, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants