feat: use navigation builder for desktop and mobile links#1235
feat: use navigation builder for desktop and mobile links#1235danielroe merged 5 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Looking into the Type errors right now. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe PR introduces typed navigation types in Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
app/types/navigation.ts (1)
15-17: Consider adding an optional identifier toNavigationSeparator.Adding a
nameproperty toNavigationSeparatorwould enable consistent keying in Vue templates (as seen withNavigationGroup.name) and avoid relying on array indices.♻️ Suggested enhancement
export type NavigationSeparator = { + name?: string type: 'separator' }
|
Thanks for your first contribution, @bdbch! 💫 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
This PR moves the navigation into it's own configuration object to make the configuration for both - desktop & mobile easier & less prone for errors.