Skip to content

fix: skip displaying packages with undefined dist tags in org route #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Jan 26, 2026
Merged

fix: skip displaying packages with undefined dist tags in org route #124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb1f74
fix: skip searching packages with undefined dist tags
jonathanyeong Jan 26, 2026
1665f02
Add comments and make dist tags optional
jonathanyeong Jan 26, 2026
7cf9d17
Fix wording
jonathanyeong Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/composables/useNpmRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ async function fetchOrgPackageNames(orgName: string): Promise<string[]> {
interface MinimalPackument {
'name': string
'description'?: string
'dist-tags': Record<string, string>
// `dist-tags` can be missing in some later unpublished packages
'dist-tags'?: Record<string, string>
'time': Record<string, string>
'maintainers'?: NpmPerson[]
}
Expand All @@ -333,7 +334,10 @@ async function fetchMinimalPackument(name: string): Promise<MinimalPackument | n
* Convert packument to search result format for display
*/
function packumentToSearchResult(pkg: MinimalPackument): NpmSearchResult {
const latestVersion = pkg['dist-tags'].latest || Object.values(pkg['dist-tags'])[0] || ''
let latestVersion = ''
if (pkg['dist-tags']) {
latestVersion = pkg['dist-tags'].latest || Object.values(pkg['dist-tags'])[0] || ''
}
const modified = pkg.time.modified || pkg.time[latestVersion] || ''

return {
Expand Down Expand Up @@ -382,7 +386,8 @@ export function useOrgPackages(orgName: MaybeRefOrGetter<string>) {
const packuments = await Promise.all(batch.map(name => fetchMinimalPackument(name)))

for (const pkg of packuments) {
if (pkg) {
// Filter out any unpublished packages (missing dist-tags)
if (pkg && pkg['dist-tags']) {
Comment thread
43081j marked this conversation as resolved.
results.push(packumentToSearchResult(pkg))
}
}
Expand Down