Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JReinhold
left a comment
There was a problem hiding this comment.
my suggestions here could potentially be a longer-term solution to the unsupported parts of nuxt.
f441ce8 to
e726dde
Compare
e726dde to
eff116d
Compare
1344552 to
4478f7e
Compare
JReinhold
left a comment
There was a problem hiding this comment.
great job! I didn't look too much into the stories themselves, but it looked good.
No worries, the stories will be iterative. I will be removing them so they can be discussed in their own PR. |
4478f7e to
4778120
Compare
Improve Storybook setup
| optionalDependencies: | ||
| '@vitest/browser': 4.0.18(@voidzero-dev/vite-plus-test@0.0.0-833c515fa25cef20905a7f9affb156dfa6f151ab(@opentelemetry/api@1.9.0)(@types/node@24.10.13)(esbuild@0.27.3)(happy-dom@20.4.0)(jiti@2.6.1)(terser@5.46.0)(typescript@5.9.3)(yaml@2.8.2))(vite@7.3.1(@types/node@24.10.13)(jiti@2.6.1)(lightningcss@1.31.1)(terser@5.46.0)(yaml@2.8.2)) | ||
|
|
||
| '@vitest/expect@3.2.4': |
There was a problem hiding this comment.
Looks like the provenance check doesn't like introducing these lower version @vitest/ dependencies. Do these need an override to a higher version that's already in the repo or is there some other way to better satisfy the check?
| sharp: 0.34.5 | ||
| vite: npm:@voidzero-dev/vite-plus-core@0.0.0-833c515fa25cef20905a7f9affb156dfa6f151ab | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.0.0-833c515fa25cef20905a7f9affb156dfa6f151ab | ||
| storybook: ^10.2.7 |
There was a problem hiding this comment.
suggestion:
This looks like it would solve the provenance issue.
| storybook: ^10.2.7 | |
| storybook: ^10.2.7 | |
| '@storybook/csf-plugin': ^10.2.7 | |
| storybook@^10.2.7>@vitest/expect: ^4.0.18 | |
| storybook@^10.2.7>@vitest/spy: ^4.0.18 | |
| '@storybook/vue3-vite@9.1.2>vue-component-meta': ^3.2.4 |
I tested it in #1651
The storybook dev server still seems to start up and render the stories just fine.
|
I’m one of the maintainers of the Nuxt/Storybook module and addon. I’ve been looking through the setup and noticed a few hacks and workarounds that seem to be covering some of the rough edges between Storybook and Nuxt. Also wanted to ask if you’d be open to adding stories in the Vue format using https://github.com/tobiasdiez/storybook-vue-addon. It still has a few known issues, but seeing an open and active project like npmx use it would be a big motivation for me to spend time fixing those and would provide real-world uses cases to guide some of the design decisions. |
Hey Tobias! I noticed a few rough edges and was planning on reaching out. Let's chat on discord, I think there's a great opportunity here to make the nuxt integration as amazing as it can be! |
In this PR
todo
considerations
notes
notes to self