Skip to content

Conversation

@bluwy
Copy link
Contributor

@bluwy bluwy commented Feb 10, 2026

oxfmt doens't read .oxfmtignore so it's not really working or used and can be removed.

oxfmt recommends putting the ignores in ignorePatterns instead, but given the ignore docs/* files were actually being formatted all this time and have the prettier-ignore comments already in place, I think we can keep formatting them without ignoring completely.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 5:51pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 5:51pm
npmx-lunaria Ignored Ignored Feb 10, 2026 5:51pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This change modifies the .oxfmtignore file by removing two lines: a comment explaining why the rule existed and the ignore pattern docs/content/**/*.md. Previously, this pattern prevented formatting tools from processing Markdown files within the docs/content/ directory. With this removal, those Markdown files will now be subject to formatting processes.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately explains the rationale for removing the .oxfmtignore file and addresses oxfmt's configuration recommendations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 01ecd65 Feb 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants