Skip to content

Conversation

@mikouaji
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 12, 2026 7:56am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 12, 2026 7:56am
npmx-lunaria Ignored Ignored Feb 12, 2026 7:56am

Request Review

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This change replaces a hardcoded y‑axis label in VersionDistribution.vue with an internationalised translation: `$t('package.versions.y_axis_label')`. Corresponding localization keys were added to English and Polish locale files and the i18n schema. No component logic, exports, or control flow were modified.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no author-provided description, making it impossible to assess whether the description relates to the changeset. Add a pull request description that explains the changes made, even if brief, to clarify the purpose of this version distribution y-axis label internationalization update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/pl-PL.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@mikouaji
Copy link
Contributor Author

@serhalp I see Daniel updated the component, I've updated translation files for languages I know and the schema.
BTW I did use the trends value because all other translations in that graph config used them, we could probably have a shared config for them not to duplicate them.
I do agree we should not re-use, just thought trends were the ones to use here.

@serhalp serhalp added this pull request to the merge queue Feb 12, 2026
Merged via the queue into npmx-dev:main with commit 1679444 Feb 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants