fix: semver sorting #143
Merged
fix: semver sorting #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses the built-in compare method from the semver package.
|
@MatteoGabriele is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
danielroe
reviewed
Jan 26, 2026
app/utils/versions.ts
Outdated
| @@ -47,19 +47,7 @@ export function parseVersion(version: string): ParsedVersion { | |||
| * @returns Comparison result for sorting | |||
| */ | |||
| export function compareVersions(a: string, b: string): number { | |||
Member
There was a problem hiding this comment.
can we just use compare wherever compareVersions is used instead of wrapping it?
Contributor
Author
There was a problem hiding this comment.
Definitely! I thought about keeping the wrapper for future changes, but it's indeed cleaner to use the package's method where needed, which also eliminates the need for tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the built-in compare method from the
semverpackage.before
after
closes #139