Skip to content

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 12, 2026

This PR just removes vacations included at #1363 when running:

  • build:lunaria script: preparing lunaria files
  • i18n:check and i18n:check:fix scripts: check and fix translation files

This will keep translation statuses ok: without this PR we'll have missing entries for vacations.*, app/pages/recharging.vue is a temporal page that will be removed once we're back).

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 12, 2026 7:42pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 12, 2026 7:42pm
npmx-lunaria Ignored Ignored Feb 12, 2026 7:42pm

Request Review

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

This pull request removes vacation-related localization data from the English language files (en-GB.json and en-US.json), eliminating the a11y.vacations object and its nested properties. Correspondingly, the build tooling is updated to exclude the vacations key during JSON processing in the locale file preparation and translation comparison scripts, alongside the existing $schema exclusion.

Possibly related PRs

Suggested reviewers

  • shuuji3
  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the removal of vacations keys and their purpose.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 12, 2026
Merged via the queue into npmx-dev:main with commit 0a2b395 Feb 12, 2026
19 checks passed
@userquin userquin deleted the chore-delete-vacations-keys branch February 13, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants