You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When navigating through elements other than our own, there's a chance that the search won't be restored. Since we always use replace within the search function, the only chance for this to happen is before switching from non-search to search (for example, via browser navigation buttons).
I most likely lost this during the initial improvements. Restoring it with a micro-fix
This does not affect all improvements, since the field will always be filled in during internal navigation (filling first, then navigation)
The change modifies the watch callback for route.query.q in the useGlobalSearch composable. It adds a conditional guard that assigns the URL-derived value to the local searchQuery variable when searchQuery.value is initially empty or falsy. The existing logic that clears searchQuery when the URL value is absent remains unchanged. This represents a single-line addition with no modifications to error handling or control flow.
Possibly related PRs
fix: missed input parts on quick search #1394: Modifies the same URL-to-searchQuery synchronisation logic in the global search composable, specifically handling watchers that initialise or clear searchQuery based on route.query.q.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating through elements other than our own, there's a chance that the search won't be restored. Since we always use replace within the search function, the only chance for this to happen is before switching from non-search to search (for example, via browser navigation buttons).
I most likely lost this during the initial improvements. Restoring it with a micro-fix
This does not affect all improvements, since the field will always be filled in during internal navigation (filling first, then navigation)