Skip to content

fix(i18n): add some missing text for zh-CN#1473

Merged
danielroe merged 4 commits intonpmx-dev:mainfrom
craigary:zh-cn-translation
Feb 13, 2026
Merged

fix(i18n): add some missing text for zh-CN#1473
danielroe merged 4 commits intonpmx-dev:mainfrom
craigary:zh-cn-translation

Conversation

@craigary
Copy link
Contributor

Add missing vacation notice for zh-CN.

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 6:35pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 6:35pm
npmx-lunaria Ignored Ignored Feb 13, 2026 6:35pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

This pull request adds two new translation keys to the Chinese locale configuration files. The copy_version key is introduced under the package section, and the has_replacement key is added under the dependencies section. These changes affect both the main locale file and the Lunaria configuration file, with a total of 3 lines added and 1 line removed across both files.

Suggested reviewers

  • danielroe
  • KazariEX
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description states 'Add missing vacation notice for zh-CN', but the actual changes add translation keys for 'copy_version' and 'has_replacement', with no vacation notice visible in the file changes. Update the PR description to accurately reflect the changes made: adding translation keys for version copying and dependency replacement guidance in zh-CN locale files.
✅ Passed checks (1 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe changed the title feat(i18n): add vacation notice for zh-CN fix(i18n): add some missing text for zh-CN Feb 13, 2026
@danielroe danielroe added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit cd0a1a1 Feb 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants