fix: dialog title switch with select#1497
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughWeeklyDownloadStats.vue now computes a dynamic Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
d5af1dd to
d0d5404
Compare
This seems to be more correct since this translation this removes is "Weekly Downloads" which is only applicable to the non-modal downloads chart. I assume that was just missed when the modal chart was expanded from just being weekly downloads.
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Hey! Thank you for your PR - I've made a change to use package.trends.items.downloads instead of package.downloads.modal_title since that seems to be more correct as package.downloads.modal_title was translated as "Weekly Downloads" which isn't the case for the modal anymore as you can change the period that the downloads/likes/contributors are shown over
Dialog title doesn't match facet
Fixed