Skip to content

fix: dialog title switch with select#1497

Merged
ghostdevv merged 5 commits intonpmx-dev:mainfrom
zzxming:fix-dialog-title
Feb 14, 2026
Merged

fix: dialog title switch with select#1497
ghostdevv merged 5 commits intonpmx-dev:mainfrom
zzxming:fix-dialog-title

Conversation

@zzxming
Copy link
Contributor

@zzxming zzxming commented Feb 14, 2026

Dialog title doesn't match facet

image

Fixed

image

@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 14, 2026 3:28pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 14, 2026 3:28pm
npmx-lunaria Ignored Ignored Feb 14, 2026 3:28pm

Request Review

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/WeeklyDownloadStats.vue 20.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

WeeklyDownloadStats.vue now computes a dynamic modalTitle from route.query.facet (supports likes, contributors, default downloads) and passes it to PackageChartModal via :title="modalTitle". The component binding replaced the previous static translation key. A CSS override sets the VueUi Sparkline text font-family to Geist Mono, monospace. Several locale files and i18n/schema.json had the downloads.modal_title key removed.

Possibly related PRs

Suggested reviewers

  • graphieros
  • danielroe
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is related to the changeset, explaining the issue of dialog title mismatching the selected facet and showing before/after screenshots of the fix.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

This seems to be more correct since this translation this removes is
"Weekly Downloads" which is only applicable to the non-modal downloads
chart. I assume that was just missed when the modal chart was expanded
from just being weekly downloads.
@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/ar-EG.json Localization changed, will be marked as complete.
lunaria/files/bg-BG.json Localization changed, will be marked as complete.
lunaria/files/de-DE.json Localization changed, will be marked as complete.
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/es-419.json Localization changed, will be marked as complete.
lunaria/files/es-ES.json Localization changed, will be marked as complete.
lunaria/files/fr-FR.json Localization changed, will be marked as complete.
lunaria/files/ja-JP.json Localization changed, will be marked as complete.
lunaria/files/pl-PL.json Localization changed, will be marked as complete.
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for your PR - I've made a change to use package.trends.items.downloads instead of package.downloads.modal_title since that seems to be more correct as package.downloads.modal_title was translated as "Weekly Downloads" which isn't the case for the modal anymore as you can change the period that the downloads/likes/contributors are shown over

@ghostdevv ghostdevv added this pull request to the merge queue Feb 14, 2026
Merged via the queue into npmx-dev:main with commit 1df3966 Feb 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants