Skip to content

fix: correct package weekly download stats safe-size#1698

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
alexdln:fix/downloads-stats-size
Feb 27, 2026
Merged

fix: correct package weekly download stats safe-size#1698
danielroe merged 1 commit intonpmx-dev:mainfrom
alexdln:fix/downloads-stats-size

Conversation

@alexdln
Copy link
Member

@alexdln alexdln commented Feb 27, 2026

🧭 Context

There's too much space under the weekly download graph on package pages. The problem is that when we were adjusting the dimensions to fix the CLS, we set the height of the entire dropdown (including the heading) to the content. Updated it to fit the content dimensions only

before/after image image

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 27, 2026 0:23am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 27, 2026 0:23am
npmx-lunaria Ignored Ignored Feb 27, 2026 0:23am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6eb04f and ae30c6b.

📒 Files selected for processing (1)
  • app/components/Package/WeeklyDownloadStats.vue

📝 Walkthrough

Walkthrough

This pull request modifies the WeeklyDownloadStats.vue component, specifically adjusting the vertical space allocated for the weekly sparkline visualisation. The container height is reduced from 110 pixels to 76 pixels, with corresponding responsive adjustments for motion-safe displays from 140 pixels to 92 pixels plus 0.75 rem. The change consists of a single-line modification affecting only the layout dimension with no alterations to data handling, state management, or event logic.

Possibly related PRs

Suggested reviewers

  • danielroe
  • 43081j
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the issue: excessive space under the weekly download graph was caused by incorrect height sizing that included the heading. The fix adjusts the height to fit content dimensions only, with before/after visual comparison provided.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 27, 2026
Merged via the queue into npmx-dev:main with commit d2dbe53 Feb 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants