Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe organisation packages endpoint's validation pattern was changed: the Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
server/api/registry/org/[org]/packages.get.ts (1)
4-4: Fix typo and wording in the validation comment.Line 4 contains spelling/wording issues (
url-sage symbold) that reduce readability.✏️ Suggested wording
-// Validation pattern for npm org names - url-sage symbold and not start with a dot (incl. ~test24214. or -ex~-) +// Validation pattern for npm org names: URL-safe symbols, and must not start with a dot (e.g. ~test24214., -ex~-)
🔗 Linked issue
Related post - bsky.app
🧭 Context
We had a very basic rule that was much stricter than what is available in npm
In npm [as I found] only two rules - url-safe symbols and does not start with a dot:
https://www.npmjs.com/org/~test24214.https://www.npmjs.com/org/-ex~-📚 Description
Updated regexp to match npm rules