Skip to content

fix(ui): link "Help translate npmx" to actionable, canonical i18n landing page#1805

Merged
danielroe merged 1 commit intomainfrom
serhalp/fix-translate-link
Mar 1, 2026
Merged

fix(ui): link "Help translate npmx" to actionable, canonical i18n landing page#1805
danielroe merged 1 commit intomainfrom
serhalp/fix-translate-link

Conversation

@serhalp
Copy link
Copy Markdown
Member

@serhalp serhalp commented Mar 1, 2026

🔗 Linked issue

N/A

🧭 Context

The "Help translate npmx" link goes directly to a directory on the GitHub repo. This isn't very actionable.

📚 Description

We have a landing page for i18n and it links out to further details about contributing. Link to that.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Building Building Preview, Comment Mar 1, 2026 9:25pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Mar 1, 2026 9:25pm
npmx-lunaria Ignored Ignored Mar 1, 2026 9:25pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d0ae04 and f048e34.

📒 Files selected for processing (1)
  • app/pages/settings.vue

📝 Walkthrough

Walkthrough

The app/pages/settings.vue file has been modified to update the "simple help" link within the LANGUAGE settings section. The link destination changed from pointing to the GitHub locales tree to directing to i18n.npmx.dev. Correspondingly, the associated icon was updated from a GitHub icon to a languages icon. The changes involve 2 additions and 2 deletions with no alterations to the underlying logic or control flow.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the rationale for updating the translation help link from GitHub to a landing page.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch serhalp/fix-translate-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Mar 1, 2026
Merged via the queue into main with commit db94835 Mar 1, 2026
21 checks passed
@danielroe danielroe deleted the serhalp/fix-translate-link branch March 1, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants