Skip to content

feat: make playgrounds section collapsible#1813

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
bluwy:playground-collapse
Mar 2, 2026
Merged

feat: make playgrounds section collapsible#1813
danielroe merged 2 commits intonpmx-dev:mainfrom
bluwy:playground-collapse

Conversation

@bluwy
Copy link
Contributor

@bluwy bluwy commented Mar 2, 2026

🔗 Linked issue

n/a

🧭 Context

Before, the playground (try it out) section isn't collapsible and not properly indented (https://npmx.dev/package/jotai):

image

I think it should be consistent with the other sections.

📚 Description

Now, it is collapsible and indented (http://localhost:3000/package/jotai):

image

@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 2, 2026 3:18am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 2, 2026 3:18am
npmx-lunaria Ignored Ignored Mar 2, 2026 3:18am

Request Review

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70a8794 and 9d82407.

📒 Files selected for processing (1)
  • app/components/CollapsibleSection.vue

📝 Walkthrough

Walkthrough

The PR moves overflow handling out of an element-level class and into the collapsed-state CSS selector in CollapsibleSection.vue (removing the overflow-hidden class and adding overflow: hidden under the collapsed selector while preserving grid-template-rows: 0fr). Playgrounds.vue replaces a static section and heading with a CollapsibleSection instance (id="playgrounds", title bound to i18n) without altering inner dropdown logic or event handling. No public APIs or component signatures were changed.

Possibly related PRs

Suggested reviewers

  • graphieros
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the changes: making the playgrounds section collapsible and properly indented to match other sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31033e7 and 70a8794.

📒 Files selected for processing (2)
  • app/components/CollapsibleSection.vue
  • app/components/Package/Playgrounds.vue

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe danielroe added this pull request to the merge queue Mar 2, 2026
Merged via the queue into npmx-dev:main with commit a90ec6b Mar 2, 2026
18 checks passed
@bluwy bluwy deleted the playground-collapse branch March 2, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants