Skip to content

feat: add marko playground links#1927

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
LuLaValva:main
Mar 4, 2026
Merged

feat: add marko playground links#1927
ghostdevv merged 1 commit intonpmx-dev:mainfrom
LuLaValva:main

Conversation

@LuLaValva
Copy link
Contributor

screenshot of the 'try it out' tab on Marko's page in npmx, with a link to the playground

🔗 Linked issue

I didn't make one 😳, sorry everybody

🧭 Context

The maintainers here did an amazing job of making the link detection for playgrounds generic and extensible. Any chance we can add Marko to the mix?

📚 Description

We don't really have a primary brand color since we're sort of "the rainbow", but we often lean on the dark red part of our logo so I chose that one. Hope it's not too close to any other playground colors!

@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev (canary) Ready Ready Preview, Comment Mar 4, 2026 5:53pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 4, 2026 5:53pm
npmx-lunaria Ignored Ignored Mar 4, 2026 5:53pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b803a3c0-e60a-48fc-9d51-9bf6519639e8

📥 Commits

Reviewing files that changed from the base of the PR and between f3403eb and 0b92a72.

📒 Files selected for processing (3)
  • app/components/Package/Playgrounds.vue
  • server/utils/readme.ts
  • uno.config.ts

📝 Walkthrough

Walkthrough

This pull request adds support for the Marko playground as a new provider. The changes span three files: the Playgrounds component is updated with icon and colour mappings for the Marko provider, the server utility that defines playground providers is extended with Marko playground configuration including domain and path details, and the design token configuration is updated to include the brand colour for the Marko provider.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the addition of Marko playground support with context about brand colour selection.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv
Copy link
Contributor

Do you have a package name I can test this with? @LuLaValva

@LuLaValva
Copy link
Contributor Author

Yeah! The playground is actually only referenced in the next version of the Marko README, here:

https://npmx.dev/package/marko/v/6.0.152

Thanks for checking this out so quickly!

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np! ty!

@ghostdevv
Copy link
Contributor

vercels preview button isn't working here for some reason, so for posterity the example can be found here: https://npmx-4reksi68z-npmx.vercel.app/package/marko/v/6.0.152

@ghostdevv ghostdevv added this pull request to the merge queue Mar 4, 2026
Merged via the queue into npmx-dev:main with commit 6a5e6b2 Mar 4, 2026
19 checks passed
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Thanks for your first contribution, @LuLaValva! ⭐

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants