fix: the weekly data anomaly detection was broken for the Svelte anomalies#1983
Conversation
Was broken for the Svelte data anomalies.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request modifies the weekly anomaly detection logic in Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
graphieros
left a comment
There was a problem hiding this comment.
Looks good to me, as it catches full & partial weekly overlaps.
And thanks for the test :)
|
Thanks for your first contribution, @samal-rasmussen! 🤩 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
The weekly data anomaly detection was broken for the Svelte anomalies
🔗 Linked issue
Follow up to PR: #1934
📚 Description
The previous code was being a bit too naive about weekly range data anomaly detection, and so wasn't including all the affected weeks properly. You actually have to check the weekly range.