refactor: remove redundant title attributes from package nav#1999
refactor: remove redundant title attributes from package nav#1999
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request removes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This is the beginning of a iterative refactor to remove
titleattributes throughout the app.These are all for the package navigation bar (on the package page). I left the
titlefor “diff” because its description was actually descriptive (eventually it will replaced with a tooltip). You could argue that they would be useful for smaller viewports, but they don’t show up on touchscreens anyway.Ideally, we’ll use tooltips instead of
titlein all situations, but our tooltip implementation is not correct (something I’ll detail more in an issue I’ll create soon, along with a proposal of how we should fix it).Further reading:
title