Skip to content

docs(ui): add stories for About page#2149

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-about-page
Mar 20, 2026
Merged

docs(ui): add stories for About page#2149
ghostdevv merged 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-about-page

Conversation

@cylewaitforit
Copy link
Contributor

@cylewaitforit cylewaitforit commented Mar 19, 2026

🔗 Linked issue

related: #2150

🧭 Context

This would also enable a storybook mock page, storybook a11y checks, and chromatic visual regression tests for this page as documented by the storybook stories.

📚 Description

Adds stories file for About page.

https://698b88d5157d89f1f33a6c21-ikqweubmyd.chromatic.com/?path=/story/pages-about--default

@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 19, 2026 11:07am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 19, 2026 11:07am
npmx-lunaria Ignored Ignored Mar 19, 2026 11:07am

Request Review

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@cylewaitforit cylewaitforit marked this pull request as ready for review March 19, 2026 11:17
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

A new Storybook story file has been created for the About component in app/pages/about.stories.ts. The file defines metadata using Meta<typeof About> and configures the story layout as fullscreen. A decorator is applied that renders the story within a page-level layout, comprising an AppHeader with logo display enabled, a main content container, and an AppFooter. A single default story with empty arguments is exported.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining that a Storybook stories file is being added for the About page to enable mock pages, a11y checks, and visual regression tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv added this pull request to the merge queue Mar 20, 2026
Merged via the queue into npmx-dev:main with commit a9d69ae Mar 20, 2026
22 of 23 checks passed
@cylewaitforit cylewaitforit deleted the sb-about-page branch March 20, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants