Skip to content

chore: migrate deprecated typescript.tsdk to js/ts.tsdk.path#2160

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
RYGRIT:chore/vscode-settings
Mar 20, 2026
Merged

chore: migrate deprecated typescript.tsdk to js/ts.tsdk.path#2160
ghostdevv merged 1 commit intonpmx-dev:mainfrom
RYGRIT:chore/vscode-settings

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Mar 20, 2026

🔗 Linked issue

🧭 Context

microsoft/vscode#303330

📚 Description

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 20, 2026 2:32am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 20, 2026 2:32am
npmx-lunaria Ignored Ignored Mar 20, 2026 2:32am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

The VS Code configuration file has been updated to use a new TypeScript SDK path setting key. The configuration previously referenced typescript.tsdk has been replaced with js/ts.tsdk.path, whilst maintaining the same value pointing to node_modules/typescript/lib. This change affects only this specific setting key mapping, with all other configuration options remaining unchanged.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is a template with no meaningful content filled in by the author, though the title and commit message indicate the change migrates a deprecated VS Code TypeScript setting. Author should provide a brief explanation of why this migration is necessary and any context from the linked GitHub issue, rather than leaving the template placeholder unfilled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv added this pull request to the merge queue Mar 20, 2026
Merged via the queue into npmx-dev:main with commit 399f7f9 Mar 20, 2026
21 checks passed
@RYGRIT RYGRIT deleted the chore/vscode-settings branch March 20, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants