Skip to content

fix: connector modal should show pnpm dlx command instead of exec#2225

Merged
ghostdevv merged 1 commit intomainfrom
g/connector-cmd
Mar 23, 2026
Merged

fix: connector modal should show pnpm dlx command instead of exec#2225
ghostdevv merged 1 commit intomainfrom
g/connector-cmd

Conversation

@ghostdevv
Copy link
Contributor

🔗 Linked issue

n/a

🧭 Context

before after
image image

📚 Description

Updates the command on the connector modal for pnpm so that it's in line with the others

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 23, 2026 4:41am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Mar 23, 2026 4:41am
npmx-lunaria Ignored Ignored Mar 23, 2026 4:41am

Request Review

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Header/ConnectorModal.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv marked this pull request as ready for review March 23, 2026 04:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3ec6277d-b23a-434b-9ca7-1dc323bace98

📥 Commits

Reviewing files that changed from the base of the PR and between 376ccec and 1f534d9.

📒 Files selected for processing (1)
  • app/components/Header/ConnectorModal.vue

📝 Walkthrough

Walkthrough

The change modifies the executeNpmxConnectorCommand computed property within the ConnectorModal Vue component. Specifically, it adds the isBinaryOnly: true flag to the options passed to getExecuteCommand for the npmx-connector package. This adjustment alters how the generated execute command is formed, whilst preserving all other command-string augmentation logic, such as the addition of --port for non-default configurations.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the update to the connector modal command for pnpm and providing visual context of the before/after states.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch g/connector-cmd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@ghostdevv ghostdevv added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit 32ba285 Mar 23, 2026
22 of 23 checks passed
@ghostdevv ghostdevv deleted the g/connector-cmd branch March 23, 2026 05:26
@github-actions github-actions bot mentioned this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants