Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe pull request updates package parameter parsing in two utility modules to handle a specific edge case: when a path contains two consecutive 'v' segments (e.g., .../v/v/...), the parser advances to treat the second 'v' as the version delimiter. This required changing Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
N/A
🧭 Context
The package route parsers were treating the first path segment equal to
vas the version delimiter. That works for normal package names, but it breaks scoped packages whose package segment is literally v, for example@scope/v.A route like
@scope/v/v/1.2.3was being parsed incorrectly as:@scopev/1.2.3instead of:
@scope/v1.2.3This affected both the Nitro segment parser and the shared string parser used by docs/skills-style routes.
📚 Description
This PR fixes both parsers to recognize
/v/as a version delimiter only in the canonical npm package position:It also adds regression tests covering scoped packages whose package segment is literally v in both parser test suites.