style: use pointer cursor for download button#2303
style: use pointer cursor for download button#2303iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/components/Package/DownloadButton.vue (1)
58-58: Use pointer cursor only when the button is enabledLine 58 applies
cursor-pointerunconditionally, so the disabled/loading state still shows a clickable cursor. Scope it to enabled state to avoid misleading affordance.Proposed tweak
- class="cursor-pointer border-border-subtle bg-bg-subtle! text-xs text-fg-muted hover:enabled:(text-fg border-border-hover)" + class="enabled:cursor-pointer border-border-subtle bg-bg-subtle! text-xs text-fg-muted hover:enabled:(text-fg border-border-hover)"
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e1b54f99-b3ec-42da-ace4-cdd13ddb3358
📒 Files selected for processing (1)
app/components/Package/DownloadButton.vue
|
@serhalp Based on our guidelines, that logic makes sense to me. I think a pointer could also give people the false impression that they could drag the download link to a bookmarks bar, however, that doesn’t work. We actually have an open issue that is seeking make cursors the default everywhere (#1760), so maybe we might be revisiting this in the near future. |
Here,